Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esLintConfig or .eslintrc not taken into account unless ejecting #5763

Closed
cyrilchapon opened this issue Nov 9, 2018 · 1 comment
Closed

Comments

@cyrilchapon
Copy link

cyrilchapon commented Nov 9, 2018

I'm trying to override eslint configuration.
(this is to add standardjs config, I'm not debating in here if it's ok or not)

Changing

{
  esLintConfig: {
    extends: "react-app"
  }
}

to

{
  esLintConfig: {
    extends: "standard"
  }
}

in package.json has no effect. Neither removing entirely esLintConfig, adding .eslintrc file or both.
npm run build doesn't complain about nothing

Just curious, I npm run ejected, and now everything works like a charm.
npm run build takes esLintConfig correctly into account.

EDIT : again, this is not a topic about standardjs or not standardjs. The topic is about configurability of shipped eslint. This is configurable/overridable when ejected, and not when not ejected

@ianschmitz
Copy link
Contributor

Please see #3886

@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants