New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--scripts-version not working with forked react-scripts #631

Closed

yesmeck opened this issue Sep 12, 2016 · 1 comment · Fixed by #632

Contributor

yesmeck commented Sep 12, 2016 •

edited

Loading

According to @gaearon's tweet https://twitter.com/dan_abramov/status/774888111927091200

I forked react-scripts to another package named feeble-scripts and tried running create-react-app myapp --scripts-version feeble-scripts, because CRA reads react-scripts's package.json in https://github.com/facebookincubator/create-react-app/blob/master/global-cli/index.js#L149-L155, so the command fails end with Error: Cannot find module '/path/to/myapp/node_modules/react-scripts/package.json'.

The text was updated successfully, but these errors were encountered:

Contributor

gaearon commented Sep 12, 2016

Apparently we broke this when we added the Node version check. Would you like to send a PR fixing this?

yesmeck mentioned this issue

Make --scripts-version work with forked react-scripts #632

Merged

gaearon closed this as completed in #632

lock bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.