Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest noFallthroughCasesInSwitch TypeScript option #6936

Closed
ianschmitz opened this issue Apr 28, 2019 · 2 comments
Closed

Suggest noFallthroughCasesInSwitch TypeScript option #6936

ianschmitz opened this issue Apr 28, 2019 · 2 comments
Labels
tag: enhancement
Milestone
4.0

Comments

@ianschmitz
Copy link
Contributor

See #6906.
@ianschmitz ianschmitz mentioned this issue Apr 28, 2019
Merged
@kentcdodds
Copy link
Contributor

This makes sense to me 👍

What needs to happen for this? Happy to help with a PR.

@ianschmitz ianschmitz added this to the 4.0 milestone Jun 10, 2020
@ianschmitz
Copy link
Contributor Author

Ooo thanks for reminding us. This was already done 😄

create-react-app/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js

Line 117 in fa648da

noFallthroughCasesInSwitch: { suggested: true },

Will be in 4.0

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@kentcdodds @ianschmitz