You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
react-app-polyfill has pinned dependencies (no '~' or '^') which makes it difficult for consumers to minimize package duplication. (Especially with core-js.)
Steps to reproduce
Create a new app which has a dependency on react-app-polyfill
Leverage another dependency which happens to use some version of 'core-js'
Downstream partner attempts to integrate your component, but their build fails because react-app-polyfill insists on a specific (potentially older) version of core-js than they are using. Error such as:
Multiple versions of core-js found: 2.5.7 D:\Code\...\core-js\2.5.7/~/core-js from D:\Code\...\react-app-polyfill\0.1.1/~/react-app-polyfill\ie11.js 2.6.10 D:\Code\...\core-js\2.6.10/~/core-js from D:\Code\...\blah\blah\blah.js
Expected behavior
I might be missing something, but I would expect that react-app-polyfill is loosely coupled to 'core-js', so should be using '~' or '^'. This would allow downstream consumers to collapse dependencies, assuming they provide a compatible version.
Reproducible demo
I didn't make one, but I can if it will be helpful.
The text was updated successfully, but these errors were encountered:
We have #6756 that will evaluate and address package pinning across all of our packages. However in this case i think we should fix the pinning in react-app-polyfill now to resolve the issues you've described that could cause duplication in the bundle.
Describe the bug
react-app-polyfill has pinned dependencies (no '~' or '^') which makes it difficult for consumers to minimize package duplication. (Especially with core-js.)
Steps to reproduce
Alternatively:
Expected behavior
I might be missing something, but I would expect that react-app-polyfill is loosely coupled to 'core-js', so should be using '~' or '^'. This would allow downstream consumers to collapse dependencies, assuming they provide a compatible version.
Reproducible demo
I didn't make one, but I can if it will be helpful.
The text was updated successfully, but these errors were encountered: