-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-scripts 3.3.0 doesn't work in development mode on IE or edge due to WebSocket constructor #8084
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Can you guys confirm that this was caused by the incorrect WS protocol? I'm hoping the fix we've merged in #8079 will fix this. |
@ianschmitz i don’t think #8079 will fix this issue. We accidentally hijacked this issue when ours was really #8075. |
This comment has been minimized.
This comment has been minimized.
I see conflicting information on that: https://msdn.microsoft.com/en-us/ie/hh772739(v=vs.94) |
I've finally had time to investigate. So to fix this, that module could be patched, or the url format could be changed to include slashes: true in the object passed. It turns out that chrome will take a url that looks like ws:localhost:3000/sockjs-node but when the websocket is created, it changes it to ws://localhost:3000/sockjs-node |
Thank you! Fix to keep monday morning deadline if anyone needs:
|
When loaded into the browser, it throws a syntax error to the console on this line:
webpackHotDevClient line 60
// Connect to WebpackDevServer via a socket.
var connection = new WebSocket(
I'm guessing this is because the constructor is not supported on edge or IE. Is there a polyfill to work around this?
The text was updated successfully, but these errors were encountered: