Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting fast refresh to false also disables automatic reload #9932

Open
Pajn opened this issue Oct 28, 2020 · 2 comments
Open

Setting fast refresh to false also disables automatic reload #9932

Pajn opened this issue Oct 28, 2020 · 2 comments

Comments

@Pajn
Copy link
Contributor

Pajn commented Oct 28, 2020

Describe the bug

When I set FAST_REFRESH=false I expect the old behaviour of a full reload of the page, but instead nothing happens.

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

FAST_REFRESH

Environment

❯ npx create-react-app --info

Environment Info:

  current version of create-react-app: 3.4.0
  running from /home/rasmus/.config/yarn/global/node_modules/create-react-app

  System:
    OS: Linux 5.8 Ubuntu 20.10 (Groovy Gorilla)
    CPU: (6) x64 Intel(R) Core(TM) i5-8600 CPU @ 3.10GHz
  Binaries:
    Node: Not Found
    Yarn: Not Found
    npm: Not Found
  Browsers:
    Chrome: 86.0.4240.111
    Firefox: 82.0
  npmPackages:
    react: ^17.0.1 => 17.0.1 
    react-dom: ^17.0.1 => 17.0.1 
    react-scripts: 4.0.0 => 4.0.0 
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

  1. Add FAST_REFRESH=false to the .env file
  2. yarn start
  3. Do a change

Expected behavior

The page reloads

Actual behavior

Nothing, I have to reload manually

Reproducible demo

N/A, just create a new app

@obsius
Copy link

obsius commented Oct 28, 2020

I had this issue and replied with a hacky work around in #9913. Looking through the file history for the hot dev client this has been fixed, but remains to be released (#9884). Any idea from the maintainers when they intend to release the next version? If fast refresh has issues (like in my case) this should be released sooner than later so folks can use the hot reload instead.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
@stale stale bot removed the stale label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants