-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sidebar collapsible on clicking label not just arrows #10854
Comments
This is a design decision we made in the past, but I agree that it could be convenient to collapse on label click, and many other docs frameworks have implemented it that way. If the community thinks it's a better default behavior, I'm happy to revisit our past design decision. Please vote here with 👍 or 👎 |
I understand this might be a design on which different people have different opinions. Would it be possible to make this a toggle / option? |
If we provide an option for each possible UI micro-interaction, we end up with a cluttered config file, which is already quite large. I don't think it's a good idea to introduce such option. There's something I don't like in the proposal:
If we are on Doc, and click on category, it doesn't necessarily mean we want to "collapse" it. An example of this unwanted behavior can be seen here: https://nextra.site/docs/docs-theme/built-ins/layout Click on the "Docs Themes" category: collapsing the full tree is confusing and not necessarily what I want. IMHO the best middle-ground option is to:
Here's an example docs implementing this pattern: https://fumadocs.vercel.app/docs/ui/openapi/proxy Click on the parent "OpenAPI" expanded category label:
Edge case: if a category has no "page" (generated index or custom markdown file), then we can always collapse it on click. Does it make sense? |
Thanks for the thorough & details answer! I hadn't considered your point about wanting to sometimes wanting to see the main category rather than collapse. I like your suggestion! |
I tried to implement this behavior in #10886 Can you please help me review it and tell me if it works as you expect? |
Is it already optimized for mobile? Or is it by design to always hide the sidebar on clicking a category? Screen_Recording_20250131_221643_Chrome.mp4 |
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
In the sidebar, is there any way to make the accordions collapsible on clicking label? It's possible to expand the accordion on first click, but on clicking an expanded accordion should collapse it. Currently, the user has to click on the accordion arrow to collapse it.
In the following video, I've attached the docusaurus docs page where the bug can be seen. I'm not sure if this is an intended thing, but seems odd UX-wise.
Screen.Recording.2025-01-21.at.2.22.15.PM.mov
Reproducible demo
No response
Steps to reproduce
Expected behavior
Clicking on an expanded accordion’s label should collapse it, providing a toggle behavior directly through the label.
Actual behavior
Clicking on the label of an expanded accordion does not collapse it. The user must click on the accordion arrow to collapse it, which results in inconsistent user experience.
Your environment
Self-service
The text was updated successfully, but these errors were encountered: