Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] use primary color for highlighted items in table of contents #1752

Closed
banli17 opened this issue Aug 9, 2019 · 4 comments
Closed

[v2] use primary color for highlighted items in table of contents #1752

banli17 opened this issue Aug 9, 2019 · 4 comments
Labels
good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@banli17
Copy link

banli17 commented Aug 9, 2019

v2 use primary color for highlighted items in table of contents
1
@banli17 banli17 changed the title v2 use primary color for highlighted items in table of contents [v2] use primary color for highlighted items in table of contents Aug 9, 2019
@wgao19
Copy link
Contributor

wgao19 commented Aug 12, 2019

I think highlighting table of content isn't implemented in v2 yet. There is a related v1 PR #1524.
Would you like to work on this?

@endiliey endiliey added 2.x good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. labels Aug 16, 2019
@banli17
Copy link
Author

banli17 commented Aug 17, 2019

i make it local，but i dont know put js where, i put css and other in website dir, but if js put in theme dir , it's strange

@wgao19
Copy link
Contributor

wgao19 commented Aug 18, 2019

I would create a component under packages/docusaurus-theme-classic/src/theme and use it in packages/docusaurus-theme-classic/src/theme/DocLegacyItem/, not sure if @endiliey or @yangshun would suggest anywhere else?

@SantiagoGdaR SantiagoGdaR mentioned this issue Oct 27, 2019
Merged
@blitz137 blitz137 mentioned this issue Oct 27, 2019
Merged
@yangshun
Copy link
Contributor

Correction - this issue is not related to #1871 (got misled by #1871's inaccurate description). #1896 is the fix in the right direction.

@endiliey endiliey closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yangshun @wgao19 @banli17 @endiliey