Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 Example Page/Index.js ProjectTitle Component Does Not Have Props #2082

Closed
FeynmanDNA opened this issue Dec 3, 2019 · 1 comment · Fixed by #2083
Closed

V1 Example Page/Index.js ProjectTitle Component Does Not Have Props #2082

FeynmanDNA opened this issue Dec 3, 2019 · 1 comment · Fixed by #2083
Labels
difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@FeynmanDNA
Copy link
Contributor

docusaurus/packages/docusaurus-1.x/examples/basics/pages/en/index.js

Line 38 in 82ded54

const ProjectTitle = () => (

I think the ProjectTitle component should have a props passed to it to be able to read siteConfig.

Otherwise this function is misleading (even though it is scoped under the class HomeSplash.)
@FeynmanDNA FeynmanDNA added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 3, 2019
@endiliey
Copy link
Contributor

endiliey commented Dec 3, 2019

Its probably a typo here in

docusaurus/packages/docusaurus-1.x/examples/basics/pages/en/index.js

Line 65 in 82ded54

<ProjectTitle siteConfig={siteConfig} />

We can just not pass props to it. Welcoming PR. This doesnt break anything anyway :)

@endiliey endiliey added difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. and removed bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 3, 2019
@FeynmanDNA FeynmanDNA mentioned this issue Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(v1): fix props for ProjectTitle FeynmanDNA/docusaurus
2 participants
@endiliey @FeynmanDNA