Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: blog-only mode blog post link is broken #2493

Closed
SamChou19815 opened this issue Apr 1, 2020 · 1 comment · Fixed by #2497
Closed

v2: blog-only mode blog post link is broken #2493

SamChou19815 opened this issue Apr 1, 2020 · 1 comment · Fixed by #2497
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Milestone
v2.0.0-alpha.50 (...

Comments

@SamChou19815
Copy link
Contributor

SamChou19815 commented Apr 1, 2020 •
edited
Loading

🐛 Bug Report

The link of blog post is prefixed with an additional /

Screen Shot 2020-04-01 at 13 05 55

Even if I manually type the correct URL, it will say page not found.

Screen Shot 2020-04-01 at 13 11 24

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

(Write your steps here:)

  1. Clone facebook/docusaurus repo
  2. remove website/src/pages/index.js
  3. Enable blog only mode by adding routeBasePath: '/', to docusaurus.config.js > presets > blog

Expected behavior

URL is not prefixed with additional /

Actual Behavior

URL prefixed with additional /

Your Environment

  • Docusaurus version used: v2-alpha-49
  • Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0): Chrome 80, Node 12
  • Operating system and version (desktop or mobile): macOS 10.15.3

Reproducible Demo

(Paste the link to an example repo, including a siteConfig.js, and exact instructions to reproduce the issue.)
@SamChou19815 SamChou19815 added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 1, 2020
@lex111 lex111 added this to the v2.0.0-alpha.50 milestone Apr 1, 2020
@lex111 lex111 removed the status: needs triage This issue has not been triaged by maintainers label Apr 1, 2020
@SamChou19815 SamChou19815 mentioned this issue Apr 2, 2020
Merged
@yangshun
Copy link
Contributor

yangshun commented Apr 2, 2020

Oops our blog-only instructions are outdated. It's updated for docs-only - https://v2.docusaurus.io/docs/next/configuration/#docs-only-mode where the routeBasePath should be ''.

But I think we can try to dedupe the slashes indeed. Thanks for the PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
v2.0.0-alpha.50 (bug fix release)
Development

Successfully merging a pull request may close this issue.

fix(v2): unbreak blog-only mode routing by deplicating starting forward slashes
3 participants
@yangshun @SamChou19815 @lex111