Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta description not formatting/removing markdown #2607

Closed
watzon opened this issue Apr 14, 2020 · 1 comment · Fixed by #2701
Closed

Meta description not formatting/removing markdown #2607

watzon opened this issue Apr 14, 2020 · 1 comment · Fixed by #2701
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@watzon
Copy link
Contributor

watzon commented Apr 14, 2020

🐛 Bug Report

I don't know if this is 100% a bug or not, but the meta description created for blog posts includes unformatted markdown.

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

Write a blog post where markdown is used in the section that will become the meta description.

Expected behavior

I'd expect markdown to be stripped out.

Actual Behavior

Markdown does not get stripped out.

Your Environment

  • Docusaurus version used: 2.0.0-alpha.50
  • Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0): Firefox 74.0.1
  • Operating system and version (desktop or mobile): Arch Linux (desktop)

Reproducible Demo

https://github.com/protoncr/tourmaline

You can also open https://tourmaline.dev/blog/another-day-another-release and check the meta description tag using the inspector. You'll see that the link is formatted as markdown still.
@watzon watzon added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 14, 2020
@yangshun yangshun mentioned this issue Apr 14, 2020
Closed
@yangshun
Copy link
Contributor

Potentially could use the same solutions as #2601

@yangshun yangshun added difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Apr 14, 2020
@lex111 lex111 mentioned this issue Apr 30, 2020
Merged
@joeporpeglia joeporpeglia mentioned this issue Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(v2): remove Markdown syntax from excerpt facebook/docusaurus
2 participants
@yangshun @watzon