Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 15 Safari URL bar covers floating secondary nav button #4927

Closed
jaredpalmer opened this issue Jun 8, 2021 · 4 comments · Fixed by #4273
Closed

iOS 15 Safari URL bar covers floating secondary nav button #4927

jaredpalmer opened this issue Jun 8, 2021 · 4 comments · Fixed by #4273
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@jaredpalmer
Copy link

No description provided.

@jaredpalmer jaredpalmer added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Jun 8, 2021
@lex111
Copy link
Contributor

lex111 commented Jun 8, 2021

Actually, we will be completely change the mobile menu UI soon, after that floating button will be removed (see #4273 (comment) for GIF demo).

@slorber
Copy link
Collaborator

slorber commented Jun 9, 2021

Can someone show a screenshot of this problem?

Is this the kind of problem we have?

image

@lex111 lex111 mentioned this issue Jun 10, 2021
Merged
@JonnyBurger
Copy link
Contributor

Here's an image

image

but it's not a dealbreaker as when you scroll, the scrollbar moves out of the way and it becomes visible again

image

@TomBrien TomBrien mentioned this issue Jun 22, 2021
Closed
@slorber slorber reopened this Jul 9, 2021
@slorber
Copy link
Collaborator

slorber commented Jul 28, 2021 •
edited
Loading

Can someone confirm if it works for this PR? #4912

Preview to check: https://deploy-preview-4912--docusaurus-2.netlify.app/docs/

Unfortunately can't check that with Browserstack or Simulator apparently...

Going to close and assume it works, let me know if it's not the case

@slorber slorber closed this as completed Jul 28, 2021
@Josh-Cena Josh-Cena removed the status: needs triage This issue has not been triaged by maintainers label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v2): redesign mobile UX: inline TOC + doc sidebar in main menu facebook/docusaurus
5 participants
@slorber @JonnyBurger @jaredpalmer @lex111 @Josh-Cena