Right and Left Arrow Event Handling #1384
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This build was not able to complete, but the tests are passing locally. Is it possible to trigger a rebuild? |
|
Hi @eessex! Thanks for adding this. I just triggered a rebuild, and in general you can also trigger a rebuild by rebasing your branch on master and force pushing your branch. Looks like tests were just failing spuriously, probably due to some issue with CI itself. I think this looks good and makes sense. I'm trying to manually test it and when I manually added an Going to debug this a little more and see if I can figure out what I'm missing. |
|
Thanks @flarnie! I'll try some manual debugging on my side as well |
|
Maybe I forgot to re-run
Adding this to the queue for merging. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
2 similar comments
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Exposes right and left keyboard events, as suggested in [this issue](facebookarchive/draft-js#219) by hellendag. This will greatly simplify some of our arrow handling at [Artsy](https://github.com/artsy/positron/blob/master/client/apps/edit/components/content2/sections/text/index.coffee#L121). The test suite is passing locally. Closes facebookarchive/draft-js#1384 Differential Revision: D5954003 fbshipit-source-id: 90c3a7d6bb5070c455f56d60ccd64c5ad136fe59
Summary: Exposes right and left keyboard events, as suggested in [this issue](facebookarchive/draft-js#219) by hellendag. This will greatly simplify some of our arrow handling at [Artsy](https://github.com/artsy/positron/blob/master/client/apps/edit/components/content2/sections/text/index.coffee#L121). The test suite is passing locally. Closes facebookarchive/draft-js#1384 Differential Revision: D5954003 fbshipit-source-id: 90c3a7d6bb5070c455f56d60ccd64c5ad136fe59
Summary: Exposes right and left keyboard events, as suggested in [this issue](facebookarchive/draft-js#219) by hellendag. This will greatly simplify some of our arrow handling at [Artsy](https://github.com/artsy/positron/blob/master/client/apps/edit/components/content2/sections/text/index.coffee#L121). The test suite is passing locally. Closes facebookarchive/draft-js#1384 Differential Revision: D5954003 fbshipit-source-id: 90c3a7d6bb5070c455f56d60ccd64c5ad136fe59
Exposes right and left keyboard events, as suggested in this issue by @hellendag.
This will greatly simplify some of our arrow handling at Artsy.
The test suite is passing locally.