Fix updating editor when editing selected text #1512
Conversation
|
Thanks for this! @existentialism do you think you could also add a test for it ? :) |
|
adding this PR to my list of PR's to test/import |
|
I'm bumping into this issue - any ETA on when this will be published? Thanks for your hard work! |
|
@mitermayer sorry for delay, in the midst of preppin' for turkey day :) will try to get a test(s) written asap! |
existentialism
force-pushed
the
issue1509
branch
2 times, most recently
from
4e59d72 to
35456c0
Compare
|
Thanks for fixing this! Looks like like this is good to merge @mitermayer? |
|
Any chance this can get merged + release? This is causing us issues in prod :) |
|
@sontek @existentialism this will get merged and releaed evtl. but just fyi the release process is a lot slower in this repository due to necessity. If you want to use it now, fork from this commit and use that until it's merged. Sry for the inconvenience, it's just that with a repository this much used it's hard to move fast :( |
existentialism
force-pushed
the
issue1509
branch
from
0727e4f to
fc10fa7
Compare
| isBackward: false, | ||
| }; | ||
|
|
||
| //const collapsedSelection = new SelectionState(DEFAULT_SELECTION); |
There was a problem hiding this comment.
Did we mean to remove this?
|
|
||
| const newEditorState = editor.update.mock.calls[0][0]; | ||
| expect(newEditorState.getCurrentContent()).toMatchSnapshot(); | ||
| }); |
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@flarnie @mitermayer thanks! |
|
I think this issue is still not solved. Text I use Can see this bug on both my website and https://draftjs.org/ |
Summary: Fixes #1509. Ref: facebookarchive/draft-js#719 Closes facebookarchive/draft-js#1512 Differential Revision: D6673593 fbshipit-source-id: fb5ab4c41de7958139deb125e5e8e79c76b53ec3
Summary: Fixes #1509. Ref: facebookarchive/draft-js#719 Closes facebookarchive/draft-js#1512 Differential Revision: D6673593 fbshipit-source-id: fb5ab4c41de7958139deb125e5e8e79c76b53ec3
Fixes #1509.
Ref: #719