Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postmortem on issue #1374? #1385

Closed
AustinConlon opened this issue May 15, 2020 · 8 comments
Closed

Postmortem on issue #1374? #1385

AustinConlon opened this issue May 15, 2020 · 8 comments

Comments

@AustinConlon
Copy link

Any chance a postmortem could be written reflecting on issue #1374?

@JCBird1012
Copy link

Time to make another one of these issues for #1427 as well (which will probably also be ignored).

@ghost
Copy link

ghost commented Jul 10, 2020

It would be very useful to have a central document that includes:

  • whether an SDK update to prevent this class of issue has been released or if a fix is planned -> this will help me prioritize upgrading the SDK.
  • notes on mitigations for older versions. e.g. Is the advice to disable automatic events logging an effective mitigation?

Currently the best documentation on this seems to be the github issues themselves, but they are very noisy to sort through.

@Jumhyn
Copy link

Jumhyn commented Jul 10, 2020

This is especially important given that the Facebook Developer Policy for Login (8.2) requires that developers use the official SDK if they support login. It's against policy to drop the SDK altogether and implement the API oneself:

  • Native iOS and Android apps that implement Facebook Login must use our official SDKs for login.

@booleanbetrayal
Copy link

booleanbetrayal commented Jul 10, 2020

@joesus - As a chief maintainer, can you provide a post-mortem on #1427 as well as #1374?

@stale
Copy link

stale bot commented Oct 12, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Oct 12, 2020
@CyberMew
Copy link

Was there ever a post mortem on this issue?

@stale stale bot removed the Stale label Oct 12, 2020
@AustinConlon
Copy link
Author

No, they decided to ignore it.

@joesus joesus closed this as completed Oct 19, 2020
@booleanbetrayal
Copy link

=[

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants