-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion when enabling .graphAPIDebugInfo
logging behavior
#2245
Fix infinite recursion when enabling .graphAPIDebugInfo
logging behavior
#2245
Conversation
|
a39293f
to
be1bf9e
Compare
|
Any chance this PR is getting some attention? There is a small and easy to understand fix that fixes an actual production crash. The community gave it to you. For free. |
I fixed the conflict |
@jjiang10, please reopen and merge this 🙏🏻 |
Any update on this? |
Seems like Meta hosts projects on GitHub, but does not care a bit about community contributions. Even if they are served to them on a silver platter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are very sorry about this. Since the editing on this codebase is going through the internal code review system, the committers are not directly looped in PRs/Issues. I will check with the team who own this part. |
@Zhiyi-Zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Zhiyi-Zhang merged this pull request in e905cac. |
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bug
for bug fixes)Pull Request Details
Fixes #2152.
Test Plan