Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion when enabling .graphAPIDebugInfo logging behavior #2245

Conversation

revolter
Copy link
Contributor

@revolter revolter commented Aug 15, 2023

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

@romarealmreborn
Copy link

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

@revolter revolter force-pushed the revolter/fix-logging-behavior-infinite-recursion branch from a39293f to be1bf9e Compare October 12, 2023 05:53
@romarealmreborn
Copy link

ผู้

@thisisthekap
Copy link

Any chance this PR is getting some attention?

There is a small and easy to understand fix that fixes an actual production crash.

The community gave it to you. For free.

@revolter
Copy link
Contributor Author

I fixed the conflict

@github-actions github-actions bot added the Stale label Apr 30, 2024
@github-actions github-actions bot closed this May 7, 2024
@revolter
Copy link
Contributor Author

revolter commented Jun 1, 2024

@jjiang10, please reopen and merge this 🙏🏻

@erdemgonul
Copy link

Any update on this?

@thisisthekap
Copy link

Seems like Meta hosts projects on GitHub, but does not care a bit about community contributions. Even if they are served to them on a silver platter.

Copy link
Contributor

@Zhiyi-Zhang Zhiyi-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zhiyi-Zhang Zhiyi-Zhang reopened this Jul 10, 2024
@Zhiyi-Zhang
Copy link
Contributor

Seems like Meta hosts projects on GitHub, but does not care a bit about community contributions. Even if they are served to them on a silver platter.

We are very sorry about this. Since the editing on this codebase is going through the internal code review system, the committers are not directly looped in PRs/Issues. I will check with the team who own this part.

@facebook-github-bot
Copy link
Contributor

@Zhiyi-Zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Zhiyi-Zhang merged this pull request in e905cac.

@revolter revolter deleted the revolter/fix-logging-behavior-infinite-recursion branch July 24, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crash when calling Settings.enableLoggingBehavior(.graphAPIDebugInfo)
6 participants