Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Framework as a swift package #2378

Open
3 tasks done
ashender opened this issue Apr 9, 2024 · 1 comment
Open
3 tasks done

Static Framework as a swift package #2378

ashender opened this issue Apr 9, 2024 · 1 comment

Comments

@ashender
Copy link

ashender commented Apr 9, 2024

Checklist before submitting a feature request

Goals

I want to install facebook-ios-sdk via SPM as a static framework to take advantage of dead code stripping and faster app launch.

Expected results

my archived iOS app binary that depends on FBSDKCoreKit.framework installed via SPM package at https://github.com/facebook/facebook-ios-sdk has all FBSDKCoreKit.framework/FBSDKCoreKit binary linked in to main app binary during static linking
otool -L MyApp
output doesn't contain FBSDK* entries

	@rpath/FBSDKShareKit.framework/FBSDKShareKit (compatibility version 1.0.0, current version 1.0.0)
	@rpath/FBAEMKit.framework/FBAEMKit (compatibility version 1.0.0, current version 1.0.0)
	@rpath/FBSDKCoreKit_Basics.framework/FBSDKCoreKit_Basics (compatibility version 1.0.0, current version 1.0.0)
	@rpath/FBSDKCoreKit.framework/FBSDKCoreKit (compatibility version 1.0.0, current version 1.0.0)

Code samples & details

add Facebook SDK via 

.package(url: "https://github.com/facebook/facebook-ios-sdk.git", from: "17.0.0"),

import and use package in the source code
@marinofelipe
Copy link

marinofelipe commented Dec 23, 2024

Are there any news on these? I'd love if a static version was made available via SPM too.
On our app all FBAEMKit, FBSDKCoreKit, FBSDKCoreKit_Basics and FBSDKLoginKit are dynamic XCFrameworks, visible via otool -L.

Let us know in case we could contribute in any way. The static SDK is available via tag, but we'd prefer the SPM integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants