After migrating to esbuild HMR no longer works on local dev plugins

[aeroxy]

Previously we use getWatchFolders for Metro to ensure local dev plugin projects are watched when running with the fast-refresh flag. After migrating to esbuild we lose this feature, and while developing local dev plugins, we would need to refresh the flipper manually and lose all the states.

[aeroxy]

@aigoncharov should look into this.

[aigoncharov]

@aeroxy the plugins are still watched (

flipper/desktop/scripts/start-dev-server.tsx

Line 416 in 277d730

await startWatchPlugins(

) and they should be reloaded automatically (https://github.com/facebook/flipper/blob/main/desktop/flipper-ui-core/src/dispatcher/pluginsSourceUpdateListener.tsx). But as you say the plugins currently lose their state.
We might build custom integration with react-refresh/runtime in future, but it is not on the roadmap though. We'd be happy to accept a PR for it though.

[aeroxy]

@aeroxy the plugins are still watched (

flipper/desktop/scripts/start-dev-server.tsx

Line 416 in 277d730

await startWatchPlugins(

) and they should be reloaded automatically (https://github.com/facebook/flipper/blob/main/desktop/flipper-ui-core/src/dispatcher/pluginsSourceUpdateListener.tsx). But as you say the plugins currently lose their state.
We might build custom integration with react-refresh/runtime in future, but it is not on the roadmap though. We'd be happy to accept a PR for it though.

Ok, let me give it a shot.

[aigoncharov]

This might be a good place to start facebook/react#16604 (comment)