Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k_limit does not increase in the second time in merging multiple digests #2388

Open
e24033150 opened this issue Feb 22, 2025 · 0 comments
Open

k_limit does not increase in the second time in merging multiple digests #2388

e24033150 opened this issue Feb 22, 2025 · 0 comments

Comments

@e24033150
Copy link

e24033150 commented Feb 22, 2025 •
edited
Loading

In TDigest.cpp, it implemented merging multiple digests and internal merge.

  • In internal merge,

    • L158 used k_limit++, I think it is correct.

  • In merging multiple digests,

    • L320 did not use ++, I think it's wrong.
      • The init value of k_limit is 1. First, it will use k_limit = 1 to calculate q_limit_times_count L320 .
      • Next time it still uses k_limit = 1 to calculate q_limit_times_count L336.
      • It would cause the second output centroid accept only one input centroid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e24033150