New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed svg example #2821

Open

k4k7us23 wants to merge 1 commit into facebook:main from k4k7us23:fix/svg_example

+33 −8

k4k7us23 commented Jan 17, 2025

Motivation

Fixes broken example of loading svg using fresco. Fixes #2820

Test Plan

Vito's java implementation

Launch showcase project
Open svg screen using sidebar menu
Enable toggle "Svg support enable"
Press "kill now" in an appeared dialog
Open showcase application
Make sure fresco's svg logo is displayed

svg shown using vito java impl

Vito's kotlin implementation

Launch showcase project
Open settings screen using sidebar menu
Enable vito -> "Use kotlin implemention" setting
Open svg screen using sidebar menu
Enable toggle "Svg support enable"
Press "kill now" in an appeared dialog
Open showcase application
Make sure fresco's svg logo is displayed

svg shown using vito kotlin impl


          Fixed svg example

8147d4b

facebook-github-bot added the CLA Signed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels