Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should be included in v0.5.1 #243

Closed
tmikov opened this issue May 14, 2020 · 7 comments
Closed

What should be included in v0.5.1 #243

tmikov opened this issue May 14, 2020 · 7 comments
Assignees
@tmikov
Labels
release

Comments

@tmikov
Copy link
Contributor

tmikov commented May 14, 2020

This issue is to discuss which fixes should be backported to the next patch release 0.5.1.
@tmikov tmikov self-assigned this May 14, 2020
@tmikov tmikov mentioned this issue May 14, 2020
Closed
@tmikov
Copy link
Contributor Author

tmikov commented May 14, 2020

The fix for #235 was already added .

@willholen
Copy link
Contributor

7bee987 adds vcruntime140_1.dll to the NPMs

@mhorowitz
Copy link
Contributor

b96f6e3 saves unstripped libraries for symbolication.

@avp
Copy link
Contributor

avp commented Jul 9, 2020

dd81112 fixes a parser bug

@tmikov
Copy link
Contributor Author

tmikov commented Jul 9, 2020

So we need PRs for all of these against the branch.

@Huxpro Huxpro mentioned this issue Jul 13, 2020
Merged
@Huxpro
Copy link
Contributor

Huxpro commented Jul 29, 2020 •
edited
Loading

For the record:

#293 also included 013566a which fixes #219.

Besides, we will also include 01906ad (#307) , 557e181 and backport changes that enable hermes-engine-darwin npm package before actually releasing v0.5.1.

@avp avp mentioned this issue Jul 31, 2020
Closed
@Huxpro
Copy link
Contributor

Huxpro commented Aug 4, 2020 •
edited
Loading

v0.5.1 is now released and published to npm. Closed.

@Huxpro Huxpro closed this as completed Aug 4, 2020
@Huxpro Huxpro added the release label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmikov tmikov

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mhorowitz @avp @Huxpro @tmikov @willholen