-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php4 style constructors halt on deprecated under php7 compatability #7229
Comments
PHP unit says this is likely an HHVM issue sebastianbergmann/phpunit#2278 (comment) |
I tried to create a small test and it seems that the deprecation message doesn't halt processing of the file:
Am I misunderstanding the issue? |
Perhaps it's just causing phpunit to halt and no longer to process files. It's not the same behavior that I'm seeing with php 7. |
Here is a travis test comparison I would re-run a current test but I'm no longer able to run HHVM tests in php 7 mode due to #7198 |
Closing as I no longer interested in HHVM. |
HHVM Version
3.12.4 / 3.14.2
Standalone code, or other way to reproduce the problem
travis ci unit test of Joomla showing the error and point processing halts
Methods with the same name as their class will not be constructors in a future version of PHP; Cache_Lite has a deprecated constructor: in JCacheStorageTest::casesGetInstance
Expected result
with PHP 7 compatability turned on php4 style constructors halt on deprecated under php7 compatability.
Deprecation messages should throw a deprecation message, and should not halt the processing of the file.
Actual result
Program halts on message :
Methods with the same name as their class will not be constructors in a future version of PHP; Cache_Lite has a deprecated constructor: in JCacheStorageTest::casesGetInstance
The text was updated successfully, but these errors were encountered: