You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Standalone code, or other way to reproduce the problem
cp hphp; test/run slow/ext_icu/uspoof.php
Expected result
Test runs cleanly
Actual result
Test fails because of conditions as described in #3925 , where one of the tests in uspoof depends on ICU 49 semantics. (I am not sure at this writing precisely which line number this test is at.)
Suggestion
The ext_icu directory has some conditional testing already in a subdirectory icu_49. Move the offending test into that subdirectory, enabling it to be skipped on newer systems, while preserving the testing on the rest of the ICU tests that are invariant under version.
This is in my brief foray into testing HHVM the last test that fails on aarch64 once the patch at #7912 is applied. It's a minor thing, but it would be a major thing to have the aarch64 CI run clean at least once.
The text was updated successfully, but these errors were encountered:
HHVM Version
HipHop Repo Compiler 3.20.0-dev (rel)
Compiler: heads/master-0-g24cd87747d9193ea227dc3406d5f3f981eb260e8
Repo schema: 5bc98bb28c29d891e958dea7d119dc42d03e780e
Standalone code, or other way to reproduce the problem
Expected result
Test runs cleanly
Actual result
Test fails because of conditions as described in #3925 , where one of the tests in uspoof depends on ICU 49 semantics. (I am not sure at this writing precisely which line number this test is at.)
Suggestion
The
ext_icu
directory has some conditional testing already in a subdirectoryicu_49
. Move the offending test into that subdirectory, enabling it to be skipped on newer systems, while preserving the testing on the rest of the ICU tests that are invariant under version.This is in my brief foray into testing HHVM the last test that fails on aarch64 once the patch at #7912 is applied. It's a minor thing, but it would be a major thing to have the aarch64 CI run clean at least once.
The text was updated successfully, but these errors were encountered: