Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stack traces without proper message #3513

Merged
merged 1 commit into from
May 11, 2017

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 8, 2017

Summary

While working on Angular integration I bumped into this issue: thymikee/jest-preset-angular#30.
For some weird reasons (probably Zone.js) error.message is not present in error.stack for some errors like it is normally on Node.

Turns errors with malformed stack trace from this:

screen shot 2017-05-08 at 11 55 06

into this:

screen shot 2017-05-08 at 11 55 11

Test plan

Integration test.

@codecov-io
Copy link

Codecov Report

Merging #3513 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
- Coverage   62.28%   62.24%   -0.04%     
==========================================
  Files         181      181              
  Lines        6700     6704       +4     
  Branches        5        5              
==========================================
  Hits         4173     4173              
- Misses       2525     2529       +4     
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-jasmine2/src/reporter.js 76.92% <0%> (-8.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992e991...48b2820. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants