jest-haste-map: add test to check duplicate modules are broken #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlauliac
force-pushed
the
test-for-duplicate-modules
branch
from
330e606
to
57afacb
Compare
jeanlauliac
force-pushed
the
test-for-duplicate-modules
branch
from
57afacb
to
e2c576c
Compare
|
Sadly |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way duplicate module IDs are handled is broken right now.
jest-haste-mapdoesn't recover from duplicate module IDs, because it systematically loose track of one of the duplicates, unable to recover it ever after. This changeset adds the structure of the test to show that it's broken, and put comment where we'll want to change the lines once it's fixed.Test plan
Unit test, no logic change.