Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust flow type for accessType parameter in spyOn function #5354

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Adjust flow type for accessType parameter in spyOn function #5354

merged 1 commit into from
Jan 20, 2018

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Jan 20, 2018

Summary

Stricter type for flow type checking, it helps developers to know exactly what are the values expected by the function.
This PR makes clear the value of accessType input parameter of spyOn function is either get or set

Test plan
NA (not a bug)

@codecov-io
Copy link

Codecov Report

Merging #5354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5354   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         205      205           
  Lines        6917     6917           
  Branches        4        4           
=======================================
  Hits         4240     4240           
  Misses       2676     2676           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19f977...887a8d3. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit d82c1c2 into jestjs:master Jan 20, 2018
@ahnpnl ahnpnl deleted the fix/spyOn-strict-flowtype branch January 20, 2018 23:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants