Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-cli] Bump node-notifier to fix a memory leak issue (fixes #5365) #5366

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

alexilyaev
Copy link
Contributor

Summary

All info in #5365 (comment)

Test plan

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SimenB
Copy link
Member

SimenB commented Jan 22, 2018

Please run yarn as well. And update the changelog

@alexilyaev
Copy link
Contributor Author

@SimenB I will.

Should I update CHANGELOG.md under msater?
Or is that done automatically somehow?

Just seen it in the template notes of the PR.

@codecov-io
Copy link

Codecov Report

Merging #5366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5366   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         205      205           
  Lines        6924     6924           
  Branches        4        4           
=======================================
  Hits         4247     4247           
  Misses       2676     2676           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139f976...68143d8. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jan 22, 2018

Under master, yes 🙂

@cpojer cpojer merged commit fec36ae into jestjs:master Jan 22, 2018
@alexilyaev
Copy link
Contributor Author

Ahm, was merged before I ran yarn and updated the changelog 😳

@alexilyaev alexilyaev deleted the patch-1 branch January 23, 2018 09:55
@SimenB
Copy link
Member

SimenB commented Jan 23, 2018

A new PR would be great 🙂

@alexilyaev
Copy link
Contributor Author

@SimenB I've cloned Jest but running yarn just hangs after a while, so can't really continue here.

yarn --verbose on a clean clone:

verbose 43.433 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/normalize-package-data/node_modules/.bin".
verbose 43.433 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/node-pre-gyp/node_modules/request/node_modules/.bin".
verbose 43.433 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/sane/node_modules".
verbose 43.434 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/tar-pack/node_modules".
verbose 43.435 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/request/node_modules/.bin".
verbose 43.436 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/sane/node_modules/.bin".
verbose 43.436 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/tabtab/node_modules/.bin".
verbose 43.436 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/tar-pack/node_modules/.bin".
verbose 43.437 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/yarn-completions/node_modules".
verbose 43.437 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/yarn/node_modules/.bin".
verbose 43.438 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/yarn-completions/node_modules/.bin".
verbose 43.438 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/fsevents/node_modules/.bin".
verbose 43.439 Removing extraneous file "/Users/alex/.config/yarn/global/node_modules/fsevents/node_modules/.bin/node-pre-gyp".
[-/3] ⢀ waiting...
[-/3] ⠠ waiting...
[2/3] ⠠ uws
[3/3] ⠠ weak
[-/3] ⠠ waiting...
[1/4] ⠄ spawn-sync
[4/4] ⠐ yarn-completions
[2/4] ⠐ fsevents: https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v59-darwin-x64.tar.gz
[3/4] ⠐ weak
[-/4] ⠐ waiting...
verbose 44.037 Tue, 23 Jan 2018 14:06:56 GMT tabtab:installer Installing completion script to bashrc directory
Tue, 23 Jan 2018 14:06:56 GMT tabtab:installer Installing completion script to /Users/alex/.bashrc directory
[-/4] ⢀ waiting...
[2/4] ⢀ fsevents: info ok
[3/4] ⢀ weak
[-/4] ⢀ waiting...
verbose 45.367 node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.6.39
node-pre-gyp info using node@9.3.0 | darwin | x64
node-pre-gyp info check checked for "/Users/alex/.config/yarn/global/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" (not found)
node-pre-gyp http GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v59-darwin-x64.tar.gz
node-pre-gyp http 200 https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v59-darwin-x64.tar.gz
node-pre-gyp info install unpacking fse.node
[-/4] ⠈ waiting...
[2/3] ⠠ uws
[3/3] ⠠ weak
[-/3] ⠠ waiting...
[-/3] ⠠ waiting...
$ yarn --version
1.3.2
$ node -v
v9.3.0
Mac OS X 10.12.6

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants