Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get builtin modules from node core #5411

Merged
merged 1 commit into from
Jan 28, 2018
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 28, 2018

Summary
We don't currently get the list of builtins from node core, as we use the wrong API. See https://nodejs.org/api/modules.html#modules_module_builtinmodules

Test plan
Tested using console.log locally on node 9.4.0 that the list exists.

@codecov-io
Copy link

codecov-io commented Jan 28, 2018

Codecov Report

Merging #5411 into master will decrease coverage by 0.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5411      +/-   ##
==========================================
- Coverage   62.26%   61.36%   -0.91%     
==========================================
  Files         205      205              
  Lines        6925     6926       +1     
  Branches        4        3       -1     
==========================================
- Hits         4312     4250      -62     
- Misses       2612     2675      +63     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-resolve/src/is_builtin_module.js 100% <ø> (ø) ⬆️
...ackages/jest-cli/src/reporters/summary_reporter.js 14.75% <0%> (-55.74%) ⬇️
packages/jest-cli/src/reporters/utils.js 61% <0%> (-29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e55c7c...d741640. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants