Adds new video page #5497
Adds new video page #5497
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
website/siteConfig.js
Outdated
| {languages: true}, | ||
| {search: true}, | ||
| {href: repoUrl, label: 'GitHub'}, | ||
| { doc: 'getting-started', label: 'Docs' }, |
There was a problem hiding this comment.
Can you revert these whitespace changes? Please run yarn lint!
There was a problem hiding this comment.
@cpojer I think there's no lint script. 🤷🏽♂️
website/siteConfig.js
Outdated
|
|
||
| const videos = [ | ||
| { | ||
| title: 'Learn how to test JavaScript with Jest', |
There was a problem hiding this comment.
Can we swap this one out with a different one?
There was a problem hiding this comment.
Oh, I thought it was removed from main page only to be included here.
|
I like it, this is awesome! Can you go on and find a number of Jest videos that you think are good that we should include on the page and post them here so we can make a selection? :) |
|
Video list so far:
@cpojer I know you might be busy, however whenever you're able to find time, could you please review these once? Thank you so much! |
|
Awesome! Let's put these into the page as a start:
I think these are already quite React heavy. The next ones we add should be less focused on React. |
|
Cool! What about your talk JSConf EU talk? Or it's better suited for homepage? |
|
Yap, we'll keep that one only on the homepage. |
|
I've updated the video list. 🙌🏽 |
|
Fantastic! Thanks so much for doing this :) I really appreciate your PR – feel free to send more PRs to make the Jest website better! |
|
@cpojer No problem at all. In fact, thank you for being so welcoming. Will definitely try to send some more PRs, hopefully code related. 🍻 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This is in response to issue #5484. As discussed, it creates a new
videospage.videoskey tositeConfigobject.Test plan
<translate>for non-static strings. Should we even translate video title/descriptions?userspage.