Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts standardize file names: Fix file names in scripts directory #5511

Merged
merged 3 commits into from
Feb 10, 2018

Conversation

ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Feb 9, 2018

Summary

A part of the process introduced in #4969
Change file names according to the decided convention:

- Files that primarily export types, objects or classes should use CapitalizedFileNames.js and should mirror what’s inside 1:1.
- Files that export a single function should have the function name with camelCase in it.
- Folder names should use dashes, unless they are special folders.
  • Removed _runCommand script as it seems that there are no usages in the codebase
  • Rename files in scripts directory only.

Test plan

Test suite is still passing

@codecov-io
Copy link

Codecov Report

Merging #5511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage   61.69%   61.69%           
=======================================
  Files         213      213           
  Lines        7077     7077           
  Branches        4        4           
=======================================
  Hits         4366     4366           
  Misses       2710     2710           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a2ea0...d19f2ab. Read the comment docs.

@cpojer cpojer merged commit 95c7e5e into jestjs:master Feb 10, 2018
@cpojer
Copy link
Member

cpojer commented Feb 10, 2018

Nice! Can you send a follow-up changing the variable name from skipOnWindows to SkipOnWindows? I admit, I never realized that it should be capitalized – you did the right thing :) Awesome!

@ranyitz
Copy link
Contributor Author

ranyitz commented Feb 10, 2018

@cpojer Thanks! I'll send a follow-up PR in a bit :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants