Use cross-spawn for running Yarn in integration tests
#5550
Conversation
| const {cleanup, run} = require('../utils'); | ||
| const runJest = require('../runJest'); | ||
|
|
||
| const dir = path.resolve(__dirname, '../coverage-remapping'); | ||
| const coverageDir = path.join(dir, 'coverage'); | ||
|
|
||
| SkipOnWindows.suite(); |
There was a problem hiding this comment.
So this is the only test that spawns different results on windows - it adds covered-test.ts next to covered.ts. Ideas what can cause that? cc @SimenB @jwbay @Aftabnack
There was a problem hiding this comment.
- Here it gets the coverage and soucemap info from the from the runner, coverage will be there only for files being used in the tests.
- But soucemaps, along with containing maps for tested code, it also contains mapping for test file itself.
- Here it iterates over sourcemaps and tries to add it to the coverage map.
My guess, this addition works for test file itself, which it doesn't in any other testcase. Do we have another testcase which is written in ts, same behaviour should be seen
thymikee
force-pushed
the
chore/appveyor-yarn
branch
from
f25d0a8
to
111e1ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #5550 +/- ##
=======================================
Coverage 61.71% 61.71%
=======================================
Files 213 213
Lines 7149 7149
Branches 3 4 +1
=======================================
Hits 4412 4412
Misses 2736 2736
Partials 1 1Continue to review full report at Codecov.
|
* Use cross-spawn for running Yarn in integration tests * Unlock more windows tests * Moar windows * Use node api instead of spawning commands to link babel-jest * Skip windows for coverage_remapping.test.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Use
cross-spawnfor running Yarn in integration tests, which should unblock running some tests on Windows.Test plan
Observe AppVeyor