Jest "Watch Usage" actions are mapping incorrectly.

[jonmajorc]

🐛 Bug Report

To Reproduce

Steps to reproduce the behavior:

1. press f to run all failing tests first. You should get "Unexpected Behavior Image 2"
2. Now press a to run all tests. You should get "Unexpected Behavior Image 1"

Expected behavior

• f should always map "to only run failed tests."
• a should always map "to run all tests."

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: macOS High Sierra 10.13.4
    CPU: x64 Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
  Binaries:
    Node: 8.9.3 - ~/.nvm/versions/node/v8.9.3/bin/node
    Yarn: 1.5.1 - /usr/local/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.9.3/bin/npm
  npmPackages:
    @types/jest: 22.2.2 => 22.2.2
    jest: 22.4.3 => 22.4.3

[SimenB]

Wow, that's weird. I can reproduce on Jest master.

/cc @rogeliog

[lgandecki]

Test like this surfaces the behavior

  it('After running failing test show the correct keys for running all/failed tests', () => {
    jest.unmock('jest-util');
    const util = require('jest-util');
    util.isInteractive = true;

    const ci_watch = require('../watch').default;
    ci_watch(globalConfig, contexts, pipe, hasteMapInstances, stdin);

    stdin.emit(KEYS.F);
    stdin.emit(KEYS.W);

    const lastWatchDisplay = pipe.write.mock.calls.reverse()[0][0];
    expect(lastWatchDisplay).toMatch('Press a to run all tests.');
    expect(lastWatchDisplay).toMatch('Press f to run only failed tests.');
  });

But looking at the code in jest/packages/jest-cli/src/watch.js it in a way seems like a bad-thought design decision more than a bug. I'd be happy to fix this, knowing how things should really work. Is it correct that f should always bind to only failed and a should always bind to all?

[SimenB]

Is it correct that f should always bind to only failed and a should always bind to all?

Yes!

[lgandecki]

Ok, looking into this more, the reason for the confusion is that F has actually a "toggle" behavior, unlike other bindings.

First time around pushing F - turns on the "only failed tests", the second time you push it - it disables it, which is probably the reason behind the label "run all tests" - which is incorrect, because, based on the context, it won't necessarily have the same result as A "running all tests", it might as well mean "go back to watch mode", if it was triggered from a watch mode.

So...
How about keeping
Press f to run only failed tests.
For enabling it, and, when it's enabled
Press f to quit "only failed tests" mode?
to disable it?

[SimenB]

Yeah, that seems reasonable to me

[lgandecki]

Fixed in the #6182 pr :-) Just got the CI to pass.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.