Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parcel bundler #10211

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Adding parcel bundler #10211

merged 4 commits into from
Jun 29, 2020

Conversation

gkanishk
Copy link
Contributor

Summary

Jest is supported and can be integrated with parcel-bundler for testing of the applications and that was not listed under documentation so added that.

Test plan

Changes were made inside the documentation part so there were no changes done in the codebase.
However, the installation code for parcel-bundler follows:

npm install -g parcel-bundler
or
yarn add parcel-bundler

@facebook-github-bot
Copy link
Contributor

Hi @gkanishk!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Jun 29, 2020

Can you add the info to https://github.com/facebook/jest/blob/master/docs/GettingStarted.md as well? Then we can merge 🙂

@gkanishk
Copy link
Contributor Author

Sure

@gkanishk
Copy link
Contributor Author

@SimenB added details inside GettingStarted.md file kindly review it.

@SimenB SimenB merged commit 22b8e85 into jestjs:master Jun 29, 2020
@SimenB
Copy link
Member

SimenB commented Jun 29, 2020

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants