Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bumps node-notifier to v8.0.0 #10400

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

mikaelbr
Copy link
Contributor

@mikaelbr mikaelbr commented Aug 13, 2020

Summary

There was an issue with Linux systems and node-notifier dependency (#9701). This PR bumps node-notifier to v8.0.0 which should fix these issues. Should get the people experiencing issues to confirm.

cc @millette @mpareja

Fixes #9701

Test plan

Shouldn't be any changes other than patch fix for Jest usage. Timeout for Linux systems will change, but no API changes. Types definitions on definitely typed aren't updated, but it is inconsequential for this PR as I see it.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! mind adding an entry to the changelog as well?

@mikaelbr
Copy link
Contributor Author

Added it now, marked as a fix and linking to this PR

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB changed the title fix: Bumps node-notifier to v8.0.0. Fixes #9701 fix: Bumps node-notifier to v8.0.0 Aug 13, 2020
@SimenB SimenB merged commit a176c30 into jestjs:master Aug 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications stopped
3 participants