-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-config): move json behind ts #10572
fix(jest-config): move json behind ts #10572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add an entry in the changelog and update the docs as well?
Hi @jackneer! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@SimenB Sure, I'd like to. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! Just updating the snapshots that CI is pointing out and this should be good to go 🙂 |
This is probably breaking? |
yup, I'd say so |
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
@jackneer this has a few outdated snapshots - could you update them? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As stated in #9834, I changed default file extension order by moving json behind ts and tsx. This modification preventing loading json over ts files. Please review, thanks!
Fixes #9834