fix(jest-config): throw correct error for missing preset modules #10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a preset module that cannot be resolved (e.g. is not npm
installed), the following error is shown to users:
● Validation Error:
Preset foobar is invalid:
The "id" argument must be of type string. Received null
Instead, the following error should be shown
● Validation Error:
Preset foobar not found.
This PR changes the error message by handling when
Resolver.findNodeModule returns null, indicating that the module cannot
be successfully imported.
terite
force-pushed
the
jest-config-preset
branch
from
a374634
to
0c52b10
Compare
SimenB
requested changes
Oct 30, 2020
| } catch {} | ||
|
|
||
| // @ts-expect-error: `presetModule` can be null? |
This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a preset module that cannot be resolved (e.g. is not npm
installed), the following error is shown to users:
Instead, the following error should be shown
This PR changes the error message by handling when
Resolver.findNodeModule returns null, indicating that the module cannot
be successfully imported.
Summary
The error currently presented when the preset module is missing is confusing, but also not the error intended to be shown.
For an example of confusion, see #10035
Test plan
To test yourself, add something like the following to your jest.config.js and observe the error message when running jest