chore: make node-notifier a peer dep

[SimenB]

Summary

node-notifier is 5MB due to the vendored binaries.

$ du -d1 -h node_modules/node-notifier
256K    node_modules/node-notifier/node_modules
 20K    node_modules/node-notifier/lib
 24K    node_modules/node-notifier/notifiers
5.4M    node_modules/node-notifier/vendor
5.7M    node_modules/node-notifier

This is the single biggest directory in node_modules of a fresh Jest install, beating out the combined @babel directory (albeit barely)

$ du -d1 -h node_modules/ | sort -hr | head
 51M    node_modules/
5.7M    node_modules//node-notifier
5.7M    node_modules//@babel
4.8M    node_modules//lodash
3.8M    node_modules//jsdom
1.2M    node_modules//acorn
1.2M    node_modules//@types
1.1M    node_modules//ajv
984K    node_modules//@jest
960K    node_modules//snapdragon

I think this should work. Hopefully the peer dep "bubbles" up so it's enough that the end user adds the dep also in PnP. node-notifier is already optional (via #8918), so the code change here is pretty trivial.

Test plan

🤞

[SimenB]

8.0.1 to include the security fix

[thymikee]

👍🏼

[merceyz]

Hopefully the peer dep "bubbles" up so it's enough that the end user adds the dep also in PnP

It wont bubble up to the user, it will probably work because of the fallback pool but turning that off will stop it

[SimenB]

Hopefully the peer dep "bubbles" up so it's enough that the end user adds the dep also in PnP

It wont bubble up to the user, it will probably work because of the fallback pool but turning that off will stop it

So for this to work properly I'll have to add the peer dependency stanza to all packages between the one that uses it and jest?

[merceyz]

Yes, there have been talks about having them bubble up but nothing has been decided yet.
There is also yarnpkg/berry#3 but that still requires declaring them

[vkrizan]

Hi, would it be possible to release this patch? Thank you.

[SimenB]

It will be part of Jest 27

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.