fix(pretty-format): handles jsdom attributes properly #11189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #10770.
When received object mismatch with expected object, jest will copy received object with
deepCyclicCopyObject
.As for this issue, received object contains jsdom provided objects
AbortController
, and will encounterjsdom/lib/jsdom/living/attributes
.This module also contains
hasAttribute
,prettyFormat.plugins.DOMElement.test
will throw an exception by callinghasAttribute
.Test plan
added
handles jsdom attributes properly
test.