fix(expect): improve typings of toThrow() and toThrowError() matchers

[mrazauskas]

Resolves #10087

Summary

It looks like the typings issue described in #10087 is caused by definition of Constructable in expect package – https://github.com/facebook/jest/blob/f13abff8df9a0e1148baf3584bcde6d1b479edc7/packages/expect/src/types.ts#L93-L95

In @types/jest it is defined differently:

interface Constructable {
  new (...args: any[]): any;
}

Changing unknowns back into anys solves the issue.

It is possible to revert back or to move forward and to use ErrorConstructor instead of Constructable. This solves the problem as well and is more explicit, right?

Test plan

Added tests. As usual.

[codecov-commenter]

Codecov Report

Merging #11929 (245dbbb) into main (f13abff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11929   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files         322      322           
  Lines       16589    16589           
  Branches     4786     4786           
=======================================
  Hits        11405    11405           
  Misses       5152     5152           
  Partials       32       32           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13abff...245dbbb. Read the comment docs.

[SimenB]

this should probably be just be just error?: unknown for the same reason TS has made stuff in catch unknown by default in strict mode: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables

[SimenB]

same below, the implementation is identical: https://github.com/facebook/jest/blob/f13abff8df9a0e1148baf3584bcde6d1b479edc7/packages/expect/src/toThrowMatchers.ts#L144-L147

(should remove one of them...)

[SimenB]

I'm actually working on typing the entire expect package better right now. Good timing! 😀 (I haven't touched specific matchers, tho, so no overlap with this PR)

[SimenB]

@mrazauskas also, could you add a test? Sorta like https://github.com/facebook/jest/pull/11931/files#diff-63545bc97334ebcdd928dfcccddf0afd945a7c2a797fb0fc5c499b3fd4184439

[mrazauskas]

Sure. I will add a test too.

[SimenB]

You run the type tests via yarn test-types in root, btw. In this case a test doesn't matter much, but we should expand our type tests, and this seems like a nice one to have as we build it up 🙂

[SimenB]

Thanks!

[mrazauskas]

By the way, if it is not overlapping, I could add type tests for other matchers too. That was fun.

[SimenB]

That'd be awesome! ❤️

I don't have any plans to do more work for the types now (and if I do it'll be how to add custom matchers, not messing with the ones we have 🙂)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.