Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jest-each): %# is not replaced with index of the test case #12517

Merged
merged 2 commits into from
Mar 1, 2022
Merged

fix(jest-each): %# is not replaced with index of the test case #12517

merged 2 commits into from
Mar 1, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Feb 28, 2022

Summary

fix #12291

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @F3n67u!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@F3n67u F3n67u force-pushed the fix/support-placeholder branch 2 times, most recently from 63e8fd1 to 302b7c6 Compare February 28, 2022 15:19
SimenB
SimenB approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! nice and minimal fix (and good tests!) 👍

Could you add a changelog entry as well?

e2e/native-esm/__tests__/native-esm.test.js Outdated Show resolved Hide resolved
@F3n67u
Copy link
Contributor Author

F3n67u commented Feb 28, 2022

thanks! nice and minimal fix (and good tests!) 👍

Could you add a changelog entry as well?

Changelog entry added.

@SimenB
Copy link
Member

SimenB commented Feb 28, 2022

Thanks! Just need to fix the CLA then (the bot is a bit slow, so if you've already signed it'll show up eventually)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 28, 2022

Tests are failing, could you take a look?

@F3n67u
Copy link
Contributor Author

F3n67u commented Mar 1, 2022 •
edited
Loading

Tests are failing, could you take a look?

fixed. thanks for your kind review.

@SimenB SimenB merged commit e4a796d into jestjs:main Mar 1, 2022
@F3n67u F3n67u deleted the fix/support-placeholder branch March 1, 2022 08:11
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: replacment string for index of the test case for .each is wrong in documentation
3 participants
@F3n67u @facebook-github-bot @SimenB