Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-test-result): add duration property to JSON test output #12518

Merged
merged 5 commits into from
Mar 1, 2022
Merged

feat(jest-test-result): add duration property to JSON test output #12518

merged 5 commits into from
Mar 1, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Mar 1, 2022 •
edited
Loading

Summary

fix #12451

Test plan

@F3n67u F3n67u marked this pull request as draft March 1, 2022 01:44
@F3n67u F3n67u force-pushed the feat/output-json-add-duration branch from 3c5e6e6 to 1554227 Compare March 1, 2022 02:09
@F3n67u F3n67u force-pushed the feat/output-json-add-duration branch from 1554227 to 1a66bb0 Compare March 1, 2022 02:15
@F3n67u F3n67u marked this pull request as ready for review March 1, 2022 02:16
SimenB
SimenB approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

e2e/__tests__/jsonReporter.test.ts Outdated Show resolved Hide resolved
e2e/json-reporter/__tests__/sum.test.js Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Mar 1, 2022

Hey @F3n67u it seems the updated test now fails using jasmine (0, instead of null). I think null makes sense, would you be able to update jasmine to not set duration to 0 for skipped tests?

@F3n67u
Copy link
Contributor Author

F3n67u commented Mar 1, 2022

Hey @F3n67u it seems the updated test now fails using jasmine (0, instead of null). I think null makes sense, would you be able to update jasmine to not set duration to 0 for skipped tests?

Certainly, I will fix that after work.

@SimenB
Copy link
Member

SimenB commented Mar 1, 2022

You can run the tests with jasmine by doing yarn jest-jasmine *pattern* btw

@F3n67u
Copy link
Contributor Author

F3n67u commented Mar 1, 2022 •
edited
Loading

You can run the tests with jasmine by doing yarn jest-jasmine *pattern* btw

@SimenB jasmine failed test is fixed, ready to review again😀

SimenB
SimenB approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 3fdcb0a into jestjs:main Mar 1, 2022
@F3n67u F3n67u deleted the feat/output-json-add-duration branch March 1, 2022 09:28
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to determine the time taken for each of the tests under suite from output file generated.
3 participants
@F3n67u @SimenB @facebook-github-bot