Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-core, jest-watcher)!: move TestWatcher class to jest-watcher #12652

Merged
merged 4 commits into from
Apr 8, 2022
Merged

feat(jest-core, jest-watcher)!: move TestWatcher class to jest-watcher #12652

merged 4 commits into from
Apr 8, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

As a TODO comment in jest-runner mentioned, it seems to be good idea to move TestWatcher class to jest-watcher. Noticed it while working on #12646 and just could not leave it.

Test plan

Green CI.

@@ -6,9 +6,9 @@
*
*/

import {TestWatcher} from '@jest/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the dep on @jest/core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like jest-runner did not list it as a dependency 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, haha

@jestjs jestjs deleted a comment Apr 8, 2022
@jestjs jestjs deleted a comment Apr 8, 2022
@jestjs jestjs deleted a comment Apr 8, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 09fa164 into jestjs:main Apr 8, 2022
@mrazauskas mrazauskas deleted the feat!-move-TestWatcher branch April 8, 2022 12:55
@github-actions
Copy link

github-actions bot commented May 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants