-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expect): add missing dependency jest-util
#12744
Conversation
a31b31b
to
aceeaba
Compare
aceeaba
to
c437289
Compare
Good catch! Mind updating tsconfig.json as well? EDIT: hah, good timing 😅 |
@merceyz any idea why it's failing? It's the PnP test |
Looks like an issue with the npm registry, you can try re-running the failed workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
expect
depends onjest-util
but doesn't declare it as a dependency.https://github.com/facebook/jest/blob/045367ad9ca773536a73efdfad019eeb2778ee32/packages/expect/src/asymmetricMatchers.ts#L16
Fixes https://github.com/yarnpkg/berry/runs/6157024113?check_suite_focus=true#step:4:44
Test plan