Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-transform): expose TransformerFactory type #13184

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Aug 28, 2022

Summary

This would allow to do this:

import type { TransformerFactory } from '@jest/transform';

const transformer: TransformerFactory = {
    // User will get type hint from `TransformerFactory`
    // ... implementation
}

Test plan

Green CI

@ahnpnl ahnpnl force-pushed the feat/expose-transform-factory-type branch from 7f23098 to 7b5cd3f Compare August 28, 2022 09:44
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Why draft? 😀

@ahnpnl ahnpnl marked this pull request as ready for review August 28, 2022 10:01
@ahnpnl
Copy link
Contributor Author

ahnpnl commented Aug 28, 2022

now it's no longer:)

@SimenB SimenB merged commit 6a97d00 into jestjs:main Aug 28, 2022
@SimenB
Copy link
Member

SimenB commented Sep 3, 2022

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants