Remove aliased matchers

[EduardoSCosta]

Summary

Resolve #13164

This PR:

• Removes the following matchers aliases:

.toBeCalled();
.toBeCalledTimes();
.toBeCalledWith();
.lastCalledWith();
.nthCalledWith();
.toReturn();
.toReturnTimes();
.toReturnWith();
.lastReturnedWith();
.nthReturnedWith();
.toThrowError();

• Updates tests to use native matchers;
• Removes the eliminated matchers from docs.

Test plan

New tests were not needed, but current tests were updated to use the preferred matchers.

[SimenB]

Thanks!

[mrazauskas]

Perhaps it would make sense to refactor matcher usage in tests already now? I mean, like here: https://github.com/facebook/jest/blob/835a93666a69202de2a0429cd5445cb5f56d2cea/packages/jest-reporters/src/__tests__/GitHubActionsReporter.test.ts#L84

.toHaveBeenCalledTimes() matcher works already now. Why not to use ESLint rule and to clean this up. I think that it will be very hard to maintain this PR, because one more .toBeCalledTimes() could land with just another PR. Having the ESLint rule turned on, one could prevent this.

This PR could simply remove the actual implementation. The rest could be split to a separate PR and land already now. Or?

[legobeat]

Needs rebase on main.

[G-Rath]

@SimenB since you're landing breaking changes, should we get this one landed? I'm happy to do a new PR if needed

[SimenB]

Yeah, let's do it!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.