Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjusted assert.throws error format when thrown #13322

Merged
merged 3 commits into from
Sep 28, 2022
Merged

fix: adjusted assert.throws error format when thrown #13322

merged 3 commits into from
Sep 28, 2022

Conversation

lpizzinidev
Copy link
Contributor

fixes #13264

SimenB
SimenB approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this is great!

@SimenB SimenB merged commit e341e46 into jestjs:main Sep 28, 2022
@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

https://github.com/facebook/jest/releases/tag/v29.1.0

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: assert.throws errors always formatted as not thrown
3 participants
@lpizzinidev @SimenB @facebook-github-bot