fix: add jest-worker's missing dependency #13341
Conversation
|
Hi @alexander-akait! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
SimenB
changed the title
Agreed, surprised it's not set up already |
|
Hmm, we have the rule active: https://github.com/facebook/jest/blob/3c31dd619e8c022cde53f40fa12ea2a67f4752ce/.eslintrc.cjs#L358-L372 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We use it here https://github.com/facebook/jest/blob/main/packages/jest-worker/src/workers/threadChild.ts#L9, but no in deps https://github.com/facebook/jest/blob/main/packages/jest-worker/package.json#L19
Ref: webpack-contrib/css-minimizer-webpack-plugin#198
Test plan
No need, but make sense to setup the linter (the rule for eslint) to catch these problems