Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-snapshot): Support Error.cause in snapshots #13965

Merged
merged 4 commits into from
Sep 20, 2023
Merged

feat(jest-snapshot): Support Error.cause in snapshots #13965

merged 4 commits into from
Sep 20, 2023

Conversation

dubzzz
Copy link
Contributor

@dubzzz dubzzz commented Feb 28, 2023 •
edited by SimenB
Loading

Summary

Up to now, the "error with cause" was not fully supported in snapshots. This PR adds support for it!

Fixes #11935

Test plan

Some dedicated E2E tests have been added to cover the feature.

SimenB
SimenB reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder if this should be considered a breaking change? If people snapshot errors with causes today, their snapshots will break with this change...

@SimenB SimenB added this to the Jest 30 milestone Mar 1, 2023
@SimenB SimenB added the Pinned label Mar 1, 2023
@dubzzz
Copy link
Contributor Author

dubzzz commented Mar 1, 2023

It will definitely be a breaking change 🤔

@legobeat
Copy link

legobeat commented May 1, 2023

Needs rebase on main.

@dubzzz
Copy link
Contributor Author

dubzzz commented May 1, 2023

@SimenB let me know when you want to merge it. I'll rebase it when ok to be merged

@dubzzz dubzzz mentioned this pull request Aug 22, 2023
Closed
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cbcc1fb
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/650a9909f25d940008d9dfbb
😎 Deploy Preview https://deploy-preview-13965--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@SimenB
Copy link
Member

SimenB commented Sep 20, 2023

@dubzzz hiya 👋 could you sign the CLA? 🙂

@dubzzz
Copy link
Contributor Author

dubzzz commented Sep 20, 2023

Thanks a lot @SimenB

@SimenB SimenB enabled auto-merge (squash) September 20, 2023 07:03
@dubzzz
Copy link
Contributor Author

dubzzz commented Sep 20, 2023

Yes of course I'll

@dubzzz
Copy link
Contributor Author

dubzzz commented Sep 20, 2023

Done 👍

@SimenB SimenB merged commit 571b230 into jestjs:main Sep 20, 2023
59 of 60 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
@dubzzz dubzzz deleted the to-match-snap branch October 21, 2023 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed Pinned
Projects
None yet
Milestone
Jest 30
Development

Successfully merging this pull request may close these issues.

[Feature]: Print error.cause
4 participants
@dubzzz @legobeat @SimenB @facebook-github-bot