Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): handle frozen config object #14054

Merged
merged 2 commits into from
Apr 5, 2023
Merged

fix(jest-config): handle frozen config object #14054

merged 2 commits into from
Apr 5, 2023

Conversation

mrazauskas
Copy link
Contributor

Fixes #8293

Summary

As suggested in the issue, this fix makes it possible to handle frozen object exported from Jest config file.

Test plan

Added unit test for readConfigFileAndSetRootDir() function.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@SimenB SimenB merged commit 08ef105 into jestjs:main Apr 5, 2023
@mrazauskas mrazauskas deleted the fix-handle-frozen-config-object branch April 5, 2023 08:06
DmitryMakhnev pushed a commit to DmitryMakhnev/jest that referenced this pull request May 5, 2023
* fix(jest-config): handle frozen config object

* change log entry
@github-actions
Copy link

github-actions bot commented May 6, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
@SimenB
Copy link
Member

SimenB commented Jul 4, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require of a shared config file returns unwanted rootDir field
3 participants