-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set minimum TS version to v4.5 #14542
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmm, maybe EDIT: Or maybe even |
I wanted to suggest 5.0 even before your edit showed up ;D Can't find time for thinking about it deeper at the moment. |
Sure, let's go for 5.0. It was released just over 6 months ago |
@SimenB Would be good to update the title as well for commit message. |
I've set the correct name in the auto merge (macos queue is looooong, but this'll merge in a couple of hours or so. hopefully 😀) |
Ah.. That’s smart. Invisible for the outside world (; |
Hah - I aborted the auto merge since the queue is stupid long, and forgot to change when merging manually 🙈 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
For the
import {type Thing}
syntax.https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#type-modifiers-on-import-names
Test plan
Green CI